Add checks for marker parent #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohzhiee
force-pushed
the
ign-gazebo3
branch
2 times, most recently
from
caea5d4 to
ddef663
Compare
Signed-off-by: Poh Zhi-Ee <[email protected]>
chapulina
added
bug
JShep1
suggested changes
Aug 13, 2020
Signed-off-by: Poh Zhi-Ee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #285.
As for the tests, I am unsure where to add it, since there are no existing rendering tests that I am aware of.
Also, should the test involve everything including starting a server, launching the GUI, and then using the marker service? Or should the test only involve the server and the rendering by manipulating the ECM directly?